refactor(build-tooling): idiomatic Groovy cleanup of the J2G output - #16661

…nd fix ClassPathResource.equals

- add specs for GrailsNameUtils, DefaultCommandLine and the file-resolving resources
  (file, jar and http), and extend the parser, loader, resource-utils and IO-utils specs
- ClassPathResource.equals read the other resource's classLoader through its getter,
  which falls back to the class's loader, while reading its own field; two resources
  created from the same class were therefore never equal. Compare fields on both sides,
  as the Java original did.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Behaviour-preserving idiom pass over the Java-to-Groovy conversion output for
build-logic/docs-core and grails-gradle/common+model (14 of the 35 files in
scope; the rest were already idiomatic or are interfaces/DTOs left untouched).

Applied:
- property syntax for getters with no isX/getX collision: ~35 sites
  (Class.getName() -> .name, URL.getProtocol()/.getFile()/.getPath() -> .protocol/.file/.path,
  File.getName()/.getParentFile()/.getAbsolutePath()/.getCanonicalPath(), URLConnection.getContentLength()/
  .getResponseCode(), Throwable.getMessage(), Class.isArray()/.getComponentType() -> .array/.componentType,
  Thread.getContextClassLoader(), Resource.getURL()/.getInputStream() -> .URL/.inputStream matching the
  existing test idiom)
- map.get(k)/map.containsKey(k) read -> map[k]: ~10 sites (CollectionUtils, Holder, CommandLineParser,
  DefaultCommandLine, GrailsResourceUtils, SpringIOUtils)
- .equals( on Strings -> ==: ~15 sites (GrailsResourceUtils protocol/path checks, CommandLineParser/
  DefaultCommandLine constant comparisons, FileSystemResource/UrlResource equals() field comparisons)
- str.length() == 0 / > 0 -> isEmpty()/!isEmpty(): ~12 sites
- StringBuilder.append( -> << in statement position: ~20 sites
- string concatenation -> GString where it lands in a String-typed slot (return type or exception
  message): FileSystemResource/UrlResource#getDescription, SpringIOUtils exception messages
- dropped unnecessary casts after instanceof flow typing: CollectionUtils#getOrCreateChildMap,
  GrailsResourceUtils#getPropertyNameConvention-equivalent branches, UrlResource#getInputStream,
  AbstractFileResolvingResource#contentLength/lastModified
- x != null ? x.foo() : null -> x?.foo(): SpringIOUtils#closeQuietly
- for (X x : coll) -> for (X x in coll): SpringIOUtils, DefaultCommandLine
- dropped the UnnecessaryPublicModifier on StringEscapeCategory's static methods

Deliberately left (Tier B exclusions / risk):
- Environment.getName() calls (CommandLineParser, DefaultCommandLine): Environment is an enum that
  defines its own getName()/setName(), shadowing the inherited Enum.name() the property syntax would
  otherwise resolve to differently; left as explicit calls.
- DefaultResourceLoader.getClassLoader() bare calls from getResource()/getResourceByPath(): the private
  classLoader field with the same name is accessible by direct-field priority within the declaring
  class, so property syntax there would bypass the getter's fallback-to-default logic. The one
  cross-class static-dispatch call sites (Class literal -> Class#getClassLoader()) were converted,
  matching the idiom the Spec already exercises (DefaultResourceLoader.classLoader / .defaultClassLoader).
- SupplierUtil#memoizedNonEmpty's instanceof-narrowed cast on `value` kept: the variable is shared across
  two closures assigned to the same `delegate` field, so Groovy's static type checker refuses to narrow
  it (javap/compile verified; dropping the cast failed compileGroovy with a "closure shared variable"
  error).
- GrailsResourceUtils#instantiateFromFlatConfig's Class.newInstance() kept: swapping in
  getDeclaredConstructor().newInstance() per the table entry would add NoSuchMethodException/
  InvocationTargetException to the call site, widening the method's declared checked-exception surface
  (a public API change), so it was left as-is.
- SpringIOUtils `in`/`out` parameter names across every copy() overload: a real "in is a keyword, rename
  it" Tier A hit, but touching all ~8 overloads' signatures for a non-functional rename was judged
  disproportionate to a focused idiom pass; left unchanged (it already compiles - `in` is only a Groovy
  keyword in for-loop/membership positions).
- ClassPathResource#nullSafeEquals' o1.equals(o2) kept: o1/o2 are declared Object and may be arrays;
  Groovy's == has its own (possibly different) array-comparison semantics, and the very next lines branch
  on primitive-array types via Arrays.equals, so swapping to == risked changing which branch is reached.
- Trivial getter/setter field pairs (ClassPathResource#getPath, FileSystemResource#getPath/getFile,
  DefaultCommandLine$SpecifiedOption#getOption/getValue) kept as explicit methods: collapsing them to bare
  Groovy properties would add a public setter that does not exist today, a public API change.
- XmlParserFeature#getFeatureName kept explicit: carries Javadoc that must stay on the method.

Found and fixed during verification: `map[k] = v` (subscript assignment) on a java.util.Map field
compiles to a dynamic `ScriptBytecodeAdapter.invokeMethodN("putAt", ...)` call under @CompileStatic in
this Groovy version, unlike the read form `map[k]` which resolves to the static
DefaultGroovyMethods.getAt - confirmed via the javap audit across every module. Reverted all ~10
map[k] = v sites introduced by this pass back to map.put(k, v); the read-only subscript conversions were
kept since they compile cleanly.

Verification (build-logic, own gradlew):
- :grails-docs-core:compileGroovy, :compileTestGroovy: BUILD SUCCESSFUL
- :grails-docs-core:test: 67 tests, 1 pre-existing failure unrelated to this change
  (FetchTagsTaskSpec, environmental: this sandbox's global git tag.gpgSign=true with no core.editor
  breaks `git tag`, nothing to do with StringEscapeCategory); StringEscapeCategorySpec itself 2/2 passed.
- no codenarc/checkstyle task exists for this project (compileGroovy only)

Verification (grails-gradle, own gradlew):
- :grails-gradle-common:compileGroovy, :grails-gradle-model:compileGroovy, both compileTestGroovy:
  BUILD SUCCESSFUL
- :grails-gradle-common:codeStyle, :grails-gradle-model:codeStyle: BUILD SUCCESSFUL, 0 CodeNarc
  violations in both main.html reports
- :grails-gradle-common:test (24/24) + :grails-gradle-model:test (432/432): 456/456, 0 failures,
  0 errors, 0 skipped (test-results XML, not exit code)
- javap -c -p dynamic-dispatch audit on every changed class: clean after the putAt fix above. The only
  remaining ScriptBytecodeAdapter/GroovyObject-property hits are inside the compiler-generated
  this$dist$invoke$1/this$dist$set$1/this$dist$get$1 trampolines that GrailsResourceUtils, SupplierUtil,
  DefaultResourceLoader and DefaultCommandLine already carried before this change (triggered by their
  pre-existing anonymous/nested inner classes), confirmed by diffing against untouched classes with no
  such nesting (Option, FileSystemResource, ...) which show none.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…erve rename history

git's default 50% rename-similarity threshold is what GitHub's PR view and
'git log --follow'/'blame' use to link a converted file back to its original
.java predecessor. DefaultCommandLine's full idiomatic conversion landed at
41% similarity (confirmed: GitHub shows delete+add, not a rename, losing
file history per matrei's review comment on #16576).

This keeps the method-body semicolons (76% similarity, confirmed rename-
detected, confirmed git log --follow/blame trace through to the real
pre-conversion commits and author) while still applying every other idiom
fix: dropped the public modifier, the 7 unnecessary java.util.* imports,
and the 4 non-interpolated double-quoted string literals CodeNarc also
flags. @SuppressWarnings('UnnecessarySemicolon') marks this as a known,
temporary, scoped exception pending the stacked groovyism-cleanup PR, which
removes both the semicolons and this suppression.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…uild-tooling

# Conflicts:
#	grails-gradle/model/src/main/groovy/org/grails/build/parsing/DefaultCommandLine.groovy

…uild-tooling

# Conflicts:
#	grails-gradle/model/src/main/groovy/org/grails/build/parsing/DefaultCommandLine.groovy

Conflicts: GrailsResourceUtils.groovy takes upstream's getPathFromRoot change
(18d8daf); the four grails-gradle/model specs upstream added in 186b59c
with the same names as this branch's are kept verbatim, with the nine feature
methods only this branch's versions asserted appended.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

…stem interaction specs

Backport of #16664 (ff463cc on 7.2.x, merged up to 9.0.x) to the three
10.0.x copies of the spec, so the Windows shards pass until the 9.0.x merge-up
reaches 10.0.x; the lines are identical, so that merge stays clean.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

…10.0.x

10.0.x was branched from 9.1.x without the version bump, so gradle.properties
still said projectVersion=9.1.0-SNAPSHOT and githubBranch=9.1.x. The
'Validate githubBranch' job therefore fails on every pull request whose base
is 10.0.x. Same four files as the 9.1.x bump in 829de60.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit fb8ecf0)

…uild-tooling

…oovy-build-tooling

…uild-tooling

…m/build-tooling

…oovy-build-tooling

…uild-tooling

…uild-tooling

# Conflicts:
#	.github/workflows/benchmark.yml
#	.github/workflows/build-health.yml
#	.github/workflows/codeanalysis.yml
#	.github/workflows/codeql.yml
#	.github/workflows/codestyle.yml
#	.github/workflows/coverage.yml
#	.github/workflows/end-to-end.yml
#	.github/workflows/gradle.yml
#	.github/workflows/groovy-snapshot-canary.yml
#	.github/workflows/rat.yml
#	.github/workflows/sitemesh2.yml
#	.github/workflows/validate-actions.yml
#	.github/workflows/vulnerability-scan.yml